-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address failing Sketch import #60
Comments
I was struggling with only one of my stories importing correctly in Sketch. Until I changed the querySelector configuration option. I am running an Angular storybook, so all my stories were wrapped in angular components. When I added
All my stories were imported in Sketch. |
I needed to solve a couple issues to resolve this:
By making those 2 changes I was able to get imports to work correctly. Hopefully this is helpful 🙂 |
As @chrisvxd wrote, this was an issue w/an underlying dependency (sketchapp-json-plugin) and not story2sketch (at least in my case). I was seeing the same (none of my layers could be imported) with both There's background on the cause in the html-sketchapp repo. |
Closed by #103, thanks @itsderek23! |
Initial discussion #59
Overview
Various storybooks result in the following message when importing into sketch:
This likely occurs under a variety of circumstances where
html-sketchapp
is failing to convert the markup to sketch nodes for currently unknown reasons.The goal of this issue is to document and track the failure cases, and provide a path forwards to addressing them.
Tasks
html-sketchapp
, with regression testsstory2sketch
during generationhtml-sketchapp
during generation and pluginKnown Failure Cases
The text was updated successfully, but these errors were encountered: