Bumped faraday dependency to 0.9.0 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2014 21:22
…le with any supported Ruby version
|
👍 @chriswarren can we get this merged? |
chriswarren
pushed a commit
that referenced
this pull request
May 6, 2014
Bumped faraday dependency to 0.9.0
|
Thanks for doing this. Sorry for the delay in getting it merged in. |
|
thanks @chriswarren ! |
|
Version 1.0.1 was just pushed to rubygems.org |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to issue #33, I've bumped faraday dependency to 0.9.0, and run tests. All have passed :) (439 examples, 0 failures, 1 pending).
I've removed ruby-debug dependencies from Gemfile as they are not compatible with any supported Ruby version.
It leads to rather odd case - if you try to run specs on 2.1.0 bundling does not pass as it fails to compile ruby-debug (it is for 1.8.x). On 1.8.7 it fails to bundle, too, as nokogiri no longer supports < 1.9.2.
As ruby-debug was designed to be used only with 1.8.x and it is an obsolete ruby version plus ruby-debug are purely developer dependencies, I've just removed these deps from Gemfile.