Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the code to use ES6+ features:
import
dependenciesextend
ingL.Control
to a native ESclass
export
plugin (though it's also still declared asL.Control.GlobeMiniMap
, so it's API-compatible)I was careful to only make syntax changes, and leave the code inside the functions alone.
To support these changes, I added a Webpack setup that automatically generates a UMD wrapper for the
import
s and compiles theclass
down to ES5. This does result in a ~50% increase in the size of the compiled and uglified JS (from 3375 bytes to 5264 bytes), but once this PR lands the plugin can be refactored to get the build size back down.Other changes: