Fix conflict with Exception namespace.

chrmorandi · Apr 2, 2019 · a9e3ecf · a9e3ecf
1 parent c0f4666
commit a9e3ecf
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/ActiveRecord.php b/src/ActiveRecord.php
@@ -10,7 +10,6 @@
 
 use chrmorandi\ldap\ActiveQuery;
 use chrmorandi\ldap\Connection;
-use Exception;
 use Yii;
 use yii\base\InvalidConfigException;
 use yii\db\BaseActiveRecord;
@@ -69,6 +68,8 @@ public static function find()
      * Returns the primary key name(s) for this AR class.
      * This method should be overridden by child classes to define the primary key.
      *
+     * Note that an array should be returned.
+     *
      * @return string[] the primary keys of this record.
      */
     public static function primaryKey()
@@ -87,7 +88,7 @@ public function attributes()
     }
 
     /**
-     * Inserts a row into the associated database table using the attribute values of this record.
+     * Inserts a record in the ldap using the attribute values.
      *
      * This method performs the following steps in order:
      *
@@ -97,7 +98,7 @@ public function attributes()
      *    failed, the rest of the steps will be skipped;
      * 3. call [[beforeSave()]]. If [[beforeSave()]] returns `false`,
      *    the rest of the steps will be skipped;
-     * 4. insert the record into database. If this fails, it will skip the rest of the steps;
+     * 4. insert the record into LDAP. If this fails, it will skip the rest of the steps;
      * 5. call [[afterSave()]];
      *
      * In the above step 1, 2, 3 and 5, events [[EVENT_BEFORE_VALIDATE]],
@@ -120,9 +121,9 @@ public function attributes()
      *
      * @param bool $runValidation whether to perform validation (calling [[validate()]])
      * before saving the record. Defaults to `true`. If the validation fails, the record
-     * will not be saved to the database and this method will return `false`.
-     * @param string[]|null $attributes    list of attributes that need to be saved.
-     * Defaults to null, meaning all attributes that are loaded from DB will be saved. meaning all attributes that are loaded from DB will be saved.
+     * will not be saved to the LDAP and this method will return `false`.
+     * @param string[]|null $attributes list of attributes that need to be saved.
+     * Defaults to null, meaning all attributes that are loaded from LDAP will be saved.
      * meaning all attributes that are loaded from DB will be saved.
      * @return bool whether the attributes are valid and the record is inserted successfully.
      */
@@ -152,6 +153,7 @@ protected function insertInternal($attributes = null)
         $primaryKey = static::primaryKey();
         $values     = $this->getDirtyAttributes($attributes);
         $dn         = $values[$primaryKey[0]];
+        //$dn         = $this->getPrimaryKey();
         unset($values[$primaryKey[0]]);
 
         static::getDb()->open();
@@ -175,7 +177,6 @@ protected function insertInternal($attributes = null)
      * @see update()
      * @param array $attributes attributes to update
      * @return integer number of rows updated
-     * @throws StaleObjectException
      */
     protected function updateInternal($attributes = null)
     {