Skip to content

Commit

Permalink
[BUG]: CIP-2 Auth Providers - Clean-up (#1025)
Browse files Browse the repository at this point in the history
- Updated logger level to avoid confusion

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Changed logger level message when registering new Auth providers to
debug to avoid confusing developers.
	 - Change the status of the CIP to `Accepted`
- Added `/docs` and `/openapi.json` to the publicly accessible endpoints
(this may or many not be a security concern - TBD)

## Test plan

Local tests are passing—no new tests.

## Documentation Changes
N/A
  • Loading branch information
tazarov committed Aug 23, 2023
1 parent 48700dd commit 1ae9485
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions chromadb/auth/registry.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import importlib
import logging
import pkgutil
from typing import Union, Dict, Type, Callable
from typing import Union, Dict, Type, Callable # noqa: F401

from chromadb.auth import (
ClientAuthConfigurationProvider,
Expand Down Expand Up @@ -47,7 +47,7 @@ def register_provider(
short_hand: str,
) -> Callable[[Type[ProviderTypes]], Type[ProviderTypes]]:
def decorator(cls: Type[ProviderTypes]) -> Type[ProviderTypes]:
logger.error("Registering provider: %s", short_hand)
logger.debug("Registering provider: %s", short_hand)
global _provider_registry
if issubclass(cls, ClientAuthProvider):
_provider_registry["client_auth_providers"][short_hand] = cls
Expand Down
2 changes: 1 addition & 1 deletion docs/CIP_2_Auth_Providers_Proposal.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Status

Current Status: `Under Discussion`
Current Status: `Accepted`

## **Motivation**

Expand Down

0 comments on commit 1ae9485

Please sign in to comment.