Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Ability to close local clients #1756

Open
eulibot opened this issue Feb 22, 2024 · 0 comments
Open

[Feature Request]: Ability to close local clients #1756

eulibot opened this issue Feb 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@eulibot
Copy link

eulibot commented Feb 22, 2024

Describe the problem

Currently, there is no way to terminate a client through the API, like via a .close() or .shutdown() function.

This may not seem necessary but I'd like to highlight one particular example where it does make a difference. While the PersistentClient is active, files are open to handle the metadata and indexing on the db. These files stay open and I'm assuming are only closed via garbage collection -- but there is no way through the API to explicitly close these files. If you want to save the db while the PersistentClient is active, this can cause "file open" issues.

Describe the proposed solution

Add a public API function to close local clients. Maybe only necessary for PersistentClient.

Alternatives considered

No response

Importance

i cannot use Chroma without it

Additional Information

No response

@eulibot eulibot added the enhancement New feature or request label Feb 22, 2024
tazarov added a commit to amikos-tech/chroma-core that referenced this issue Feb 23, 2024
tazarov added a commit to amikos-tech/chroma-core that referenced this issue Mar 21, 2024
tazarov added a commit to amikos-tech/chroma-core that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant