Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Fixed BF index overflow issue with subsequent delete #1150

Merged
merged 2 commits into from
Sep 19, 2023
Merged

[BUG]: Fixed BF index overflow issue with subsequent delete #1150

merged 2 commits into from
Sep 19, 2023

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Sep 18, 2023

Refs: #989

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • When the BF index overflows (batch_size upon insertion of large batch it is cleared, if a subsequent delete request comes to delete Ids which were in the cleared BF index a warning is raised for non-existent embedding. The issue was resolved by separately checking if BF the record exists in the BF index and conditionally execute the BF removal

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python

Documentation Changes

N/A

@tazarov
fix: Fixed BF index overflow issue
62d772f 
- When the BF index overflows (batch_size upon insertion of large batch it is cleared, if a subsequent delete request comes to delete Ids which were in the cleared BF index a warning is raised for non-existent embedding. The issue was resolved by separately checking if BF the record exists in the BF index and conditionally execute the BF removal

Refs: chroma-core#989
@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@tazarov
fix: Fixed BF index overflow issue
ef72512 
- Remove ternary expression

Refs: chroma-core#989
@HammadB HammadB enabled auto-merge (squash) September 18, 2023 17:23
auto-merge was automatically disabled September 18, 2023 18:30

Base branch was modified

@tazarov
Copy link
Contributor Author

tazarov commented Sep 18, 2023 •
edited
Loading

Interestingly this failed: https://github.com/chroma-core/chroma/actions/runs/6225881997/job/16897265310?pr=1150

I'll have a look

@HammadB
Copy link
Collaborator

HammadB commented Sep 18, 2023

Looks like a timeout. Let me rerun. We need to move that test to a larger runner

@HammadB HammadB merged commit 3aed7b7 into chroma-core:main Sep 19, 2023
82 checks passed
tazarov added a commit to amikos-tech/chroma-core that referenced this pull request Sep 19, 2023
@tazarov
[BUG]: Fixed BF index overflow issue with subsequent delete (chroma-c…
4cba82c 
…ore#1150)

Refs: chroma-core#989

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- When the BF index overflows (batch_size upon insertion of large batch
it is cleared, if a subsequent delete request comes to delete Ids which
were in the cleared BF index a warning is raised for non-existent
embedding. The issue was resolved by separately checking if BF the
record exists in the BF index and conditionally execute the BF removal

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python

## Documentation Changes
N/A
tazarov added a commit to amikos-tech/chroma-core that referenced this pull request Sep 21, 2023
@tazarov
[BUG]: Fixed BF index overflow issue with subsequent delete (chroma-c…
64bec14 
…ore#1150)

Refs: chroma-core#989

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- When the BF index overflows (batch_size upon insertion of large batch
it is cleared, if a subsequent delete request comes to delete Ids which
were in the cleared BF index a warning is raised for non-existent
embedding. The issue was resolved by separately checking if BF the
record exists in the BF index and conditionally execute the BF removal

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python

## Documentation Changes
N/A
@tazarov tazarov mentioned this pull request Jan 18, 2024
Open
@s-peryt s-peryt mentioned this pull request Apr 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tazarov @HammadB