Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Local Observability Stack with OTEL and Zipkin #1279

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Oct 24, 2023

Description of changes

Summarize the changes made by this PR.

  • New functionality
    • Added the possibility to run the observability stack (OTEL collector + Zipkin) alongside Chroma server in a docker-compose

Test plan

How are these changes tested?

  • Manual testing

Documentation Changes

Observability section on chroma docs updated - chroma-core/docs#149

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB
Copy link
Collaborator

HammadB commented Oct 24, 2023

Should we add docs about this example to docs.trychroma.com?

@HammadB HammadB closed this Oct 24, 2023
@HammadB HammadB reopened this Oct 24, 2023
@HammadB
Copy link
Collaborator

HammadB commented Oct 24, 2023

Woops

@tazarov
Copy link
Contributor Author

tazarov commented Oct 24, 2023

@HammadB, I'm fine with that. Here https://docs.trychroma.com/observability, right?

@tazarov
Copy link
Contributor Author

tazarov commented Oct 24, 2023

Done

@tazarov
Copy link
Contributor Author

tazarov commented Nov 20, 2023

@HammadB, I think you can rerun the failed tests then we this + docs PR should be ready to merge.

@tazarov
Copy link
Contributor Author

tazarov commented Nov 28, 2023

@HammadB, this is ready for merge.

Copy link
Member

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@beggers beggers merged commit aa4702b into chroma-core:main Nov 29, 2023
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants