[ENH] Add system-catalog-provider to simplify deployment

go/coordinator/cmd/grpccoordinator/cmd.go

@@ -23,6 +23,7 @@ var (
 
 func init() {
 	flag.GRPCAddr(Cmd, &conf.BindAddress)
+	Cmd.Flags().StringVar(&conf.SystemCatalogProvider, "system-catalog-provider", "memory", "System catalog provider")
 	Cmd.Flags().StringVar(&conf.Username, "username", "root", "MetaTable username")
 	Cmd.Flags().StringVar(&conf.Password, "password", "", "MetaTable password")
 	Cmd.Flags().StringVar(&conf.Address, "db-address", "127.0.0.1:3306", "MetaTable db address")

go/coordinator/internal/grpccoordinator/server.go

@@ -2,9 +2,11 @@ package grpccoordinator
 
 import (
 	"context"
+	"errors"
 
 	"github.com/chroma/chroma-coordinator/internal/coordinator"
 	"github.com/chroma/chroma-coordinator/internal/grpccoordinator/grpcutils"
+	"github.com/chroma/chroma-coordinator/internal/metastore/db/dbcore"
 	"github.com/chroma/chroma-coordinator/internal/proto/coordinatorpb"
 	"google.golang.org/grpc"
 	"google.golang.org/grpc/health"
@@ -15,6 +17,9 @@ type Config struct {
 	// GRPC config
 	BindAddress string
 
+	// System catalog provider
+	SystemCatalogProvider string
+
 	// MetaTable config
 	Username     string
 	Password     string
@@ -39,19 +44,26 @@ type Server struct {
 }
 
 func New(config Config) (*Server, error) {
-	// dBConfig := dbcore.DBConfig{
-	// 	Username:     config.Username,
-	// 	Password:     config.Password,
-	// 	Address:      config.Address,
-	// 	DBName:       config.DBName,
-	// 	MaxIdleConns: config.MaxIdleConns,
-	// 	MaxOpenConns: config.MaxOpenConns,
-	// }
-	// db, err := dbcore.Connect(dBConfig)
-	// if err != nil {
-	// 	return nil, err
-	// }
-	return NewWithGrpcProvider(config, grpcutils.Default, nil)
+	if config.SystemCatalogProvider == "memory" {
+		return NewWithGrpcProvider(config, grpcutils.Default, nil)
+	} else if config.SystemCatalogProvider == "database" {
+		dBConfig := dbcore.DBConfig{
+			Username:     config.Username,
+			Password:     config.Password,
+			Address:      config.Address,
+			DBName:       config.DBName,
+			MaxIdleConns: config.MaxIdleConns,
+			MaxOpenConns: config.MaxOpenConns,
+		}
+		db, err := dbcore.Connect(dBConfig)
+		if err != nil {
+			return nil, err
+		}
+		return NewWithGrpcProvider(config, grpcutils.Default, db)
+	} else {
+		return nil, errors.New("invalid system catalog provider, only memory and database are supported")
+	}
+
 }
 
 func NewWithGrpcProvider(config Config, provider grpcutils.GrpcProvider, db *gorm.DB) (*Server, error) {

k8s/deployment/kubernetes.yaml

@@ -264,10 +264,6 @@ spec:
         - command:
             - "chroma"
             - "coordinator"
-            - "--db-address=aws.connect.psdb.cloud"
-            - "--username=pscale_user"
-            - "--password=pscale_password"
-            - "--db-name=test"
           image: chroma-coordinator
           imagePullPolicy: IfNotPresent
           name: coordinator
@@ -293,4 +289,4 @@ spec:
       targetPort: grpc
   selector:
     app: coordinator
-  type: ClusterIP
+  type: ClusterIP