-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Cloud client #1462
Merged
Merged
[ENH] Cloud client #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
beggers
reviewed
Dec 5, 2023
beggers
reviewed
Dec 5, 2023
beggers
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds the Chroma
CloudClient
as a client type. It takes an API key (or reads it from the environment, or prompts the user for it if it's not found) , and tries to connect to the Chroma cloud using the API key.Under the hood, this is a specialized HTTPClient with ssl always turned on, and which uses token-based authentication with the API key as the token.
This PR also moves the
AuthorizationError
from auth to the general set of errors, so it can be handled elsewhere by the Chroma system.Test plan
Added a new test,
test_cloud_client
, which creates a mock 'cloud' server and then tests connection with valid and invalid API keys.Documentation Changes
Cloud is not yet available, so
CloudClient
is for now not to be used by external users of Chroma. Therefore, we won't land documentation changes with this PR.TODOs
Docs