Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add Rust Configuration #1507

Merged
merged 1 commit into from
Dec 12, 2023
Merged

[ENH] Add Rust Configuration #1507

merged 1 commit into from
Dec 12, 2023

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Dec 12, 2023

Dupe of #1500, which I accidentally mistacked not onto main. This was approved so merging it here without approval. Refer to #1500 for PR description etc.

Copy link
Collaborator Author

HammadB commented Dec 12, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB HammadB merged commit a7d93ce into main Dec 12, 2023
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant