Gemini #1520
Merged
Gemini #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
reviewed
Dec 14, 2023
examples/gemini/requirements.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| chromadb>=0.4.4 | |||
There was a problem hiding this comment.
Should we make this more restrictive?
HammadB
reviewed
Dec 14, 2023
| self._genai.embed_content( | ||
| model=self._model_name, | ||
| content=text, | ||
| task_type="retrieval_document", |
There was a problem hiding this comment.
Should we make this configurable?
HammadB
reviewed
Dec 14, 2023
| model=self._model_name, | ||
| content=text, | ||
| task_type="retrieval_document", | ||
| title="Embedding of single string", |
HammadB
reviewed
Dec 14, 2023
| class GoogleGenerativeAiEmbeddingFunction(EmbeddingFunction[Documents]): | ||
| """To use this EmbeddingFunction, you must have the google.generativeai Python package installed and have a Google API key.""" | ||
|
|
||
| """Use RETRIEVAL_DOCUMENT for the task_type for embedding, and RETRIEVAL_QUERY for the task_type for retrieval.""" |
HammadB
reviewed
Dec 14, 2023
clients/js/examples/node/app.js
Outdated
|
|
||
| var app = express(); | ||
| app.get("/", async (req, res) => { | ||
| const cc = new chroma.ChromaClient({ path: "http://localhost:8000" }); | ||
| await cc.reset(); | ||
|
|
||
| const openAIembedder = new chroma.OpenAIEmbeddingFunction("key") | ||
| const cohereAIEmbedder = new chroma.OpenAIEmbeddingFunction({ openai_api_key: "API_KEY" }); | ||
| console.log("entry") |
HammadB
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Google Gemini embedding function and an RAG chat example
TODO