Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add ingest dispatch + scheduler + segment #1542

Merged
merged 6 commits into from
Jan 16, 2024
Merged

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Dec 17, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds a tenant-level RR scheduler and uses sysdb to look up tenants, this is not cached for now.
      • The scheduler can be slept/awoken
      • Adds a segment concept with tracking for user ids -> internal ids
  • New functionality
    • /

Test plan

How are these changes tested?

  • Tests pass locally with cargo test

Apologies for the larger diff, my stack got messed up

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB HammadB changed the title [ENH] Add ingest dispatch + scheduler [ENH] Add ingest dispatch + scheduler + segment Dec 18, 2023
@HammadB HammadB mentioned this pull request Dec 18, 2023
1 task
rust/worker/src/ingest/ingest.rs Outdated Show resolved Hide resolved
@@ -286,7 +305,7 @@ impl Component for PulsarIngestTopic {
1000
}

fn on_start(&self, ctx: &ComponentContext<Self>) -> () {
fn on_start(&mut self, ctx: &ComponentContext<Self>) -> () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me why we need this. Does the change from an Arc to a Box below require that we make self mut here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm standardizing all the handlers to be mutable (handle, on start, future lifecycle methods etc) so users can mutate state if they desire.

@HammadB HammadB changed the base branch from hammad/ingest_conversion to main January 16, 2024 03:51
@HammadB HammadB merged commit 68d806c into main Jan 16, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants