Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLN] Import json at top-level in embedding_functions #1562

Merged
merged 2 commits into from
Jan 4, 2024
Merged

[CLN] Import json at top-level in embedding_functions #1562

merged 2 commits into from
Jan 4, 2024

Conversation

beggers
Copy link
Contributor

@beggers beggers commented Dec 21, 2023 •
edited
Loading

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Move import json out of Amazon Bedrock EF and to top-level imports

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@beggers beggers mentioned this pull request Dec 21, 2023
Merged
1 task
@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@beggers beggers changed the title Import json at top-level in embedding_functions [CLN] Import json at top-level in embedding_functions Jan 4, 2024
@jeffchuber jeffchuber self-requested a review January 4, 2024 17:08
@beggers beggers merged commit 920ebf3 into main Jan 4, 2024
98 checks passed
thorwhalen pushed a commit to thorwhalen/chroma that referenced this pull request Jan 11, 2024
@beggers @thorwhalen
[CLN] Import json at top-level in embedding_functions (chroma-core#1562)
309a1a8 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Move `import json` out of Amazon Bedrock EF and to top-level imports

## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python, `yarn test` for js

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https://github.com/chroma-core/docs)?*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffchuber jeffchuber jeffchuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beggers @jeffchuber