Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] fix docker don't shutdown gracefully #1648

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

nicolasgere
Copy link
Contributor

Description of changes

Test plan

How are these changes tested?
Tested locally with docker.

[notice] A new release of pip is available: 23.0.1 -> 23.3.2
[notice] To update, run: pip install --upgrade pip
DEBUG:    [16-01-2024 23:24:47] Registering provider: token_config
DEBUG:    [16-01-2024 23:24:47] Registering provider: user_token_config
DEBUG:    [16-01-2024 23:24:47] Registering provider: token
DEBUG:    [16-01-2024 23:24:47] Registering provider: token
WARNING:  [16-01-2024 23:24:47] chroma_server_nofile is set to 65535, but this is less than current soft limit of 1048576. chroma_server_nofile will not be set.
INFO:     [16-01-2024 23:24:47] Anonymized telemetry enabled. See                     https://docs.trychroma.com/telemetry for more information.
DEBUG:    [16-01-2024 23:24:47] Starting component System
DEBUG:    [16-01-2024 23:24:47] Starting component OpenTelemetryClient
DEBUG:    [16-01-2024 23:24:47] Starting component SimpleAssignmentPolicy
DEBUG:    [16-01-2024 23:24:47] Starting component SqliteDB
DEBUG:    [16-01-2024 23:24:47] Starting component Posthog
DEBUG:    [16-01-2024 23:24:47] Starting component LocalSegmentManager
DEBUG:    [16-01-2024 23:24:47] Starting component SegmentAPI
INFO:     [16-01-2024 23:24:47] Started server process [1]
INFO:     [16-01-2024 23:24:47] Waiting for application startup.
INFO:     [16-01-2024 23:24:47] Application startup complete.
INFO:     [16-01-2024 23:24:47] Uvicorn running on http://0.0.0.0:8000 (Press CTRL+C to quit)
^CINFO:     [16-01-2024 23:24:52] Shutting down
INFO:     [16-01-2024 23:24:52] Waiting for application shutdown.
INFO:     [16-01-2024 23:24:52] Application shutdown complete.
INFO:     [16-01-2024 23:24:52] Finished server process [1]

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@nicolasgere nicolasgere merged commit 8e52409 into main Jan 17, 2024
95 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants