Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF]: use tilt test ci #1727

Merged
merged 10 commits into from
Feb 22, 2024
Merged

[PERF]: use tilt test ci #1727

merged 10 commits into from
Feb 22, 2024

Conversation

nicolasgere
Copy link
Contributor

@nicolasgere nicolasgere commented Feb 15, 2024 •
edited

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Replace minikube by tilt to match local setup
    • Refactor workflow

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@nicolasgere nicolasgere force-pushed the nicolas/use-tilt-test-ci branch 3 times, most recently from 42b7d4a to 452a458 Compare February 22, 2024 01:47
@nicolasgere nicolasgere changed the title WIP: Nicolas/use tilt test ci [PERF]: use tilt test ci Feb 22, 2024
HammadB
HammadB approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the tests pass but shipt this

@nicolasgere nicolasgere merged commit 89ddcbe into main Feb 22, 2024
117 checks passed
atroyn pushed a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
@nicolasgere @atroyn
[PERF]: use tilt test ci (chroma-core#1727)
0063e45 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Replace minikube by tilt to match local setup
	 - Refactor workflow

---------

Co-authored-by: nicolas <nico@trychroma.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HammadB HammadB HammadB approved these changes

@beggers beggers beggers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolasgere @HammadB @beggers