[ENH]: add grpc python client interceptor #1802
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @nicolasgere and the rest of your teammates on |
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
nicolasgere
changed the title
| new_client_details = _ClientCallDetails( | ||
| client_call_details.method, | ||
| client_call_details.timeout, | ||
| tuple(metadata), # Ensure metadata is a tuple |
There was a problem hiding this comment.
Is there a chance metadata can contain things that cannot be properly serialized, e.g. nested or non-basic types?
There was a problem hiding this comment.
I don't expect anyone to add things to metadata.
| # Log exception details and re-raise | ||
| span.set_attribute("rpc.error", str(e)) | ||
| span.set_status(StatusCode.ERROR, description=str(e)) | ||
| raise |
There was a problem hiding this comment.
Would that not cause a failure of the GRPC message if we fail to process the trace? Should we differentiate between processing errors and GRPC invocation-related errors?
There was a problem hiding this comment.
otel should never raise, even if span is empty as far as I know
| # 1. Instantiate the interceptor: interceptors = [OtelInterceptor()] | ||
| # 2. Intercept the channel: channel = grpc.intercept_channel(channel, *interceptors) | ||
|
|
||
| class OtelInterceptor( |
There was a problem hiding this comment.
There was a problem hiding this comment.
I think it would be nice to have control over this, to help with integration with go/rust, distributed tracing, metrics etc
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Add grpc client interceptor to propagate trace information for distributed tracing. ## Test plan *How are these changes tested?* Tested locally using tilt and golang rpc
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Tested locally using tilt and golang rpc