Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Add rust client to log service #1811

Merged
merged 4 commits into from
Mar 5, 2024
Merged

[ENH] Add rust client to log service #1811

merged 4 commits into from
Mar 5, 2024

Conversation

Ishiihara
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • This PR adds functionality to read logs from log service and get collections to compact.

Test plan

How are these changes tested?

  • Unit tests

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

weiligu
weiligu approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@weiligu weiligu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's add e2e tests later

rust/worker/src/log/log.rs Outdated Show resolved Hide resolved
@Ishiihara Ishiihara changed the title Add rust client to log service [ENH] Add rust client to log service Mar 4, 2024
HammadB
HammadB reviewed Mar 4, 2024
View reviewed changes
rust/worker/src/log/log.rs Outdated Show resolved Hide resolved
HammadB
HammadB reviewed Mar 4, 2024
View reviewed changes
rust/worker/src/log/log.rs Outdated Show resolved Hide resolved
HammadB
HammadB reviewed Mar 4, 2024
View reviewed changes
rust/worker/src/log/log.rs Outdated Show resolved Hide resolved
HammadB
HammadB reviewed Mar 4, 2024
View reviewed changes
rust/worker/src/log/log.rs Outdated Show resolved Hide resolved
HammadB
HammadB reviewed Mar 4, 2024
View reviewed changes
rust/worker/src/log/log.rs Outdated Show resolved Hide resolved
HammadB
HammadB reviewed Mar 4, 2024
View reviewed changes
rust/worker/src/log/log.rs Outdated Show resolved Hide resolved
HammadB
HammadB requested changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's return Result<> where appropriate and define our Error types. You can take a look at sysdb.rs for this
  • I find the naming incongruence between the service definition and the client a bit odd. Can you explain the reasoning here? Also things like get_collections() and index feel like confusing names, can we improve those? Aligning with the service definition is an easy win, but open to other ideas. The service definition has verbose, but clear names.
  • You can make your impl of Try_From on the Box<>'ed type instead. Box::new() will perform an allocation so we'd prefer one-copy reads of the record.

These should be pretty quick changes !! Thanks. Looks great otherwise.

HammadB
HammadB reviewed Mar 5, 2024
View reviewed changes
rust/worker/src/types/embedding_record.rs
let proto_submit = record_log.record.unwrap();
let proto_submit = record_log
.record
.ok_or(EmbeddingRecordConversionError::DecodeError(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice use of ok_or!

@Ishiihara Ishiihara merged commit ab6007e into chroma-core:main Mar 5, 2024
118 checks passed
atroyn pushed a commit to csbasil/chroma that referenced this pull request Apr 3, 2024
@Ishiihara @atroyn
[ENH] Add rust client to log service (chroma-core#1811)
1463059 
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - ...
 - New functionality
- This PR adds functionality to read logs from log service and get
collections to compact.

## Test plan
*How are these changes tested?*

- [ ] Unit tests

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https://github.com/chroma-core/docs)?*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiligu weiligu weiligu approved these changes

@HammadB HammadB HammadB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ishiihara @weiligu @HammadB