Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLD] Fix for JS package in GH #2345

Merged
merged 2 commits into from
Jun 19, 2024
Merged

[BLD] Fix for JS package in GH #2345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9f4983
fix: Org scope for package.json for JS release package
tazarov Jun 15, 2024
71ec343
chore: Adding token in setup-node action
tazarov Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/release-javascript-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,19 @@ jobs:
with:
node-version: "16.x"
registry-url: ${{ matrix.registry }}
check-latest: false
token: ${{ matrix.registry == 'https://registry.npmjs.org' && secrets.NPM_TOKEN || secrets.GITHUB_TOKEN }}
- name: Install dependencies
run: npm install
working-directory: ./clients/js/
- name: Update package.json with organization scope
if: matrix.registry == 'https://npm.pkg.github.com'
run: |
# needed to publish to GitHub packages only
ORG_NAME="@chroma-core"
PACKAGE_NAME=$(jq -r '.name' package.json)
jq --arg org "$ORG_NAME" --arg name "$PACKAGE_NAME" '.name = "\($org)/\($name)"' package.json > tmp.$$.json && mv tmp.$$.json package.json
working-directory: ./clients/js/
- name: Test & publish
run: npm run db:run && PORT=8001 npm run $NPM_SCRIPT
working-directory: ./clients/js/
Expand Down
Loading