Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Enable test_embeddings #2376

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[ENH] Enable test_embeddings #2376

merged 1 commit into from
Jun 19, 2024

Conversation

sanketkedia
Copy link
Contributor

@sanketkedia sanketkedia commented Jun 19, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes get_vectors brute force add and update logic to account for uninitialized segment
    • Fixes get_vectors brute force update logic to also account for adds that happened in the log and not in the segment
    • Fixes get_vectors to return ids and embeddings in the same order as the input search ids. This is necessary since the FE relies on this
    • Fixes get_vectors to also get triggered on updates/deletes of records that were added in the log itself
    • Enables test_embeddings for cluster integration tests

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

@sanketkedia sanketkedia requested a review from HammadB June 19, 2024 05:27
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@HammadB
Copy link
Collaborator

HammadB commented Jun 19, 2024

!!!MERGE!!!!

@sanketkedia sanketkedia merged commit afe53b2 into main Jun 19, 2024
65 checks passed
Anush008 pushed a commit to Anush008/chroma that referenced this pull request Jun 27, 2024
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Fixes get_vectors brute force add and update logic to account for
uninitialized segment
- Fixes get_vectors brute force update logic to also account for adds
that happened in the log and not in the segment
- Fixes get_vectors to return ids and embeddings in the same order as
the input search ids. This is necessary since the FE relies on this
- Fixes get_vectors to also get triggered on updates/deletes of records
that were added in the log itself
    - Enables test_embeddings for cluster integration tests

## Test plan
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants