Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dockerfile to include a version of gcc that supports C++11 #738

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

petersolimine
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
  • New functionality
    • Added gcc and g++ to the list of installed packages in the builder image. This enables hnswlib to build properly.

Test plan

How are these changes tested?
I recommend building the Docker image and running a container from it to ensure that everything runs smoothly.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

No documentation changes are needed. However, it might be useful to build and push these changes to the image: ghcr.io/chroma-core/chroma:latest to resolve any issues with the docker-compose.server.example.yml file.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

Dockerfile Outdated
@@ -13,6 +15,11 @@ RUN pip install --no-cache-dir --upgrade --prefix="/install" -r requirements.txt

FROM python:3.10-slim-bullseye as final

RUN apt-get update && apt-get install -y \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need compilers in final image,
they have already served their purpose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is necessary, because the Docker script is currently configured to rebuild hnswlib on boot (which is necessary to make sure that hnswlib's capabilities match the actual hardware (e.g AVX/AVX2/AVX512).

Originally we only built hnswlib when building the docker image, but then if you ran it on a different kind of CPU from the one used to build it it could cause errors. This is a case where Docker is a leaky abstraction.

@levand
Copy link
Contributor

levand commented Jul 22, 2023

This should also solve #721 (the problem there isn't that it's a cross platform build, it's that the build tools are now required at runtime.)

@jeffchuber jeffchuber self-requested a review July 24, 2023 15:58
Copy link
Contributor

@jeffchuber jeffchuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, with @levand as well

@jeffchuber jeffchuber merged commit d609804 into chroma-core:main Jul 24, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue building docker-compose.server.example.yml file
4 participants