Turn on strict types (!) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
commented
Sep 18, 2023
ghengeveld
approved these changes
Sep 18, 2023
Merged
8 tasks
ndelangen
added a commit
to storybookjs/storybook
that referenced
this pull request
Sep 18, 2023
…uild-page Closes chromaui/addon-visual-tests#110 (comment) ## What I did - I changed the type-interface of `experimental_updateStatus` so it allows `null` as a value to indicate it should delete the status on a story. The runtime code was already correct. We didn't catch this because `manager-api` is still `strict:false` in `tsconfig.json`. ## Checklist for Contributors ### Testing <!-- Please check (put an "x" inside the "[ ]") the applicable items below to communicate how to test your changes --> #### The changes in this PR are covered in the following automated tests: - [ ] stories - [ ] unit tests - [ ] integration tests - [ ] end-to-end tests #### Manual testing I tested this manually, by changing `strict:false` to `true` and checking if it does not produce an error for that line. TS does produce an error, when I removed the `| null`, so I think that means this change is correct. ### Documentation <!-- Please check (put an "x" inside the "[ ]") the applicable items below to indicate which documentation has been updated. --> - [ ] Add or update documentation reflecting your changes - [ ] If you are deprecating/removing a feature, make sure to update [MIGRATION.MD](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md) ## Checklist for Maintainers - [ ] When this PR is ready for testing, make sure to add `ci:normal`, `ci:merged` or `ci:daily` GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in `code/lib/cli/src/sandbox-templates.ts` - [ ] Make sure this PR contains **one** of the labels below: <details> <summary>Available labels</summary> - `bug`: Internal changes that fixes incorrect behavior. - `maintenance`: User-facing maintenance tasks. - `dependencies`: Upgrading (sometimes downgrading) dependencies. - `build`: Internal-facing build tooling & test updates. Will not show up in release changelog. - `cleanup`: Minor cleanup style change. Will not show up in release changelog. - `documentation`: Documentation **only** changes. Will not show up in release changelog. - `feature request`: Introducing a new feature. - `BREAKING CHANGE`: Changes that break compatibility in some way with current major version. - `other`: Changes that don't fit in the above categories. </details> ### 🦋 Canary release <!-- CANARY_RELEASE_SECTION --> This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the `@storybookjs/core` team here. _core team members can create a canary release [here](https://github.com/storybookjs/storybook/actions/workflows/canary-release-pr.yml) or locally with `gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>`_ <!-- CANARY_RELEASE_SECTION -->
ndelangen
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a pretty smooth process, a couple callouts.
📦 Published PR as canary version:
0.0.79--canary.110.4594b11.0✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.79--canary.110.4594b11.0 # or yarn add @chromaui/addon-visual-tests@0.0.79--canary.110.4594b11.0