generated from storybookjs/addon-kit
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Test Addon Onboarding behind query param #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clude joyride onboarding.
…uild flow. Heuristic for showing still a wip
…n't work if current story has no changes
…ests into matt/ap-3586-product-tour-of-vt-features
…ral seems not to load.
weeksling
force-pushed
the
matt/ap-3586-product-tour-of-vt-features
branch
from
November 15, 2023 20:05
21600c9
to
d05fb8c
Compare
weeksling
force-pushed
the
matt/ap-3586-product-tour-of-vt-features
branch
from
November 16, 2023 19:30
07acde6
to
f6a37cf
Compare
…oes not quite work as expected. Some issues with chromatic build so can't test properly
…ests into matt/ap-3586-product-tour-of-vt-features
…ng-onboarding-routing' into matt/ap-3586-product-tour-of-vt-features
… build has changes
ghengeveld
reviewed
Nov 20, 2023
…thub.com/chromaui/storybook-visual-tests into matt/ap-3586-product-tour-of-vt-features
weeksling
changed the title
product tour of vt features
Visual Test Addon Onboarding behind query param
Jan 27, 2024
thafryer
added
minor
Auto: Increment the minor version when merged
release
Auto: Create a `latest` release when merged
labels
Jan 31, 2024
thafryer
removed
release
Auto: Create a `latest` release when merged
minor
Auto: Increment the minor version when merged
labels
Jan 31, 2024
thafryer
force-pushed
the
matt/ap-3586-product-tour-of-vt-features
branch
from
February 1, 2024 01:51
232ca3f
to
ddbd39c
Compare
thafryer
force-pushed
the
matt/ap-3586-product-tour-of-vt-features
branch
from
February 1, 2024 02:09
ddbd39c
to
6590d7e
Compare
tmeasday
added
minor
Auto: Increment the minor version when merged
skip-release
Auto: Preserve the current version when merged
labels
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
minor
Auto: Increment the minor version when merged
skip-release
Auto: Preserve the current version when merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve AP-4116, AP-4126, AP-4127, AP-4133, AP-4115, AP-4110
This adds addon onboarding, with steps:
To enable the onboarding, add the
&vtaOnboarding=true
query param to your storybook url.To test, you will want to try this out in these different scenarios:
📦 Published PR as canary version:
1.0.1--canary.144.53a44d0.0
✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@1.0.1--canary.144.53a44d0.0 # or yarn add @chromaui/addon-visual-tests@1.0.1--canary.144.53a44d0.0