Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Test Addon Onboarding behind query param #144

Merged
merged 91 commits into from Feb 1, 2024

Conversation

weeksling
Copy link
Contributor

@weeksling weeksling commented Nov 7, 2023

Resolve AP-4116, AP-4126, AP-4127, AP-4133, AP-4115, AP-4110

This adds addon onboarding, with steps:

  • Initital Build flow - to prompt brand new projects to create a first build baseline before testing changes.
  • Make a Change flow - force the user to create a local change, and run a local build to test for changes. (will rerun if the build does not have any changes caught).
  • Done screen - displays if the last build did have changes, and prompts user to continue to guided walkthrough.
  • Guided Tour - once a build exists with changes, guide the user through the story filters, review screens, accepting a story, and rerunning builds.

To enable the onboarding, add the &vtaOnboarding=true query param to your storybook url.

To test, you will want to try this out in these different scenarios:

  1. Create a brand new project on Chromatic (no builds) and add the addon. Onboarding will guide you through creating very first build, making a change, and then the guided tour.
  2. Add the addon to a project with existing builds on Chromatic. Onboarding will skip ahead to make a change and running second build.
  3. Opening a branch with an existing build that has changes. Onboarding will show you the Done screen, and then begin the guided tour (this will be updated to skip ahead to the guided tour without the done screen. Was kept to get a version of the onboarding out - this is a less common edge case).
📦 Published PR as canary version: 1.0.1--canary.144.53a44d0.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@1.0.1--canary.144.53a44d0.0
# or 
yarn add @chromaui/addon-visual-tests@1.0.1--canary.144.53a44d0.0

@weeksling weeksling force-pushed the matt/ap-3586-product-tour-of-vt-features branch from 21600c9 to d05fb8c Compare November 15, 2023 20:05
@weeksling weeksling force-pushed the matt/ap-3586-product-tour-of-vt-features branch from 07acde6 to f6a37cf Compare November 16, 2023 19:30
@weeksling weeksling changed the title product tour of vt features Visual Test Addon Onboarding behind query param Jan 27, 2024
@thafryer thafryer added minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged labels Jan 31, 2024
@thafryer thafryer removed release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Jan 31, 2024
@thafryer thafryer force-pushed the matt/ap-3586-product-tour-of-vt-features branch from 232ca3f to ddbd39c Compare February 1, 2024 01:51
@thafryer thafryer force-pushed the matt/ap-3586-product-tour-of-vt-features branch from ddbd39c to 6590d7e Compare February 1, 2024 02:09
@tmeasday tmeasday added minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged labels Feb 1, 2024
@tmeasday tmeasday merged commit 96fcdc8 into main Feb 1, 2024
6 checks passed
@tmeasday tmeasday deleted the matt/ap-3586-product-tour-of-vt-features branch February 1, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants