Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticate with Chromatic CLI using OAuth token rather than projectToken #145

Merged
merged 5 commits into from
Nov 17, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 8, 2023

Fixes AP-3383

📦 Published PR as canary version: 0.0.118--canary.145.0d30dd8.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.118--canary.145.0d30dd8.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.118--canary.145.0d30dd8.0

@ghengeveld ghengeveld marked this pull request as ready for review November 13, 2023 14:21
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also stop writing the project token to chromatic.config.json right?

src/Panel.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@weeksling weeksling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghengeveld ghengeveld merged commit 5ff4984 into main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants