Align changed story count in notification and sidebar #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thafryer
force-pushed
the
jarel/ap-3894-number-of-changes-in-notification-doesnt-match-number-in
branch
from
04928d3
to
4207700
Compare
|
QA Looks Good. 
|
thafryer
commented
Feb 24, 2024
tmeasday
reviewed
Feb 25, 2024
tmeasday
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a discrepancy in the change count used in the notification and the sidebar. The Sidebar showed the number of stories with changes. The notification showed the number of changes across all modes and browsers. So, this PR adjusts the count shown in the notification to align with the sidebar.
To QA
📦 Published PR as canary version:
1.1.11--canary.189.4207700.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.1.11--canary.189.4207700.0 # or yarn add @chromatic-com/storybook@1.1.11--canary.189.4207700.0