Prevent flashing wrong screen by increasing timeout #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
changed the title
thafryer
approved these changes
Mar 5, 2024
ghengeveld
deleted the
ghengeveld/ap-4193-flash-of-the-wrong-view-during-onboarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had a timeout in place to prevent flashing the wrong screen, but it wasn't long enough. Extending it to 10 seconds ensures we only reset the
uncommittedHashwhile the new build is underway, thereby preventing the wrong screen from appearing. Arguably this is not the most reliable solution but a proper fix would be way more involved and this is likely good enough.📦 Published PR as canary version:
1.2.4--canary.195.ca78be3.0✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.2.4--canary.195.ca78be3.0 # or yarn add @chromatic-com/storybook@1.2.4--canary.195.ca78be3.0