-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only use criteria to select mode when story first loads #218
Conversation
play: playAll(async ({ canvasElement, canvasIndex }) => { | ||
const canvas = within(canvasElement); | ||
const menu = await canvas.findByRole("button", { name: "Safari" }); | ||
await userEvent.click(menu); | ||
const items = await screen.findAllByText("Chrome"); | ||
await userEvent.click(items[canvasIndex]); | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this play
function since useTests
now selects the first non-passed test/comparison by default. But, this story's comment kind of sounds like we expected to show the first passed test by default. Since that is no longer the case, is this story still valid at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop the play
function, instead update the code comment above and update the snapshot.
@ghengeveld I made some updates to fix some |
QA
📦 Published PR as canary version:
1.2.22--canary.218.31120f4.0
✨ Test out this PR locally via:
npm install @chromatic-com/storybook@1.2.22--canary.218.31120f4.0 # or yarn add @chromatic-com/storybook@1.2.22--canary.218.31120f4.0