Add toggle to show baseline snapshot image #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-3440 Add toggle to show baseline snapshot image
We will show a toggle in the bottom toolbar for switching between snapshots. It will look like this by default when a change is detected: Lastest - Visual testing in Storybook (Figma) And, when switched, like this: |
weeksling
force-pushed
the
matt/ap-3440-add-toggle-to-show-baseline-snapshot-image
branch
2 times, most recently
from
ee59263
to
0f94197
Compare
weeksling
commented
Aug 18, 2023
There was a problem hiding this comment.
This is a bit garbled because I reordered the icons.
The extra changes here were:
- Moved the toggle diff button to the end of the icons where it is in designs.
- Added the WithTooltip to the icons.
The new
weeksling
commented
Aug 18, 2023
There was a problem hiding this comment.
The new changes are around line 170.
tmeasday
approved these changes
Aug 23, 2023
| @@ -52,6 +52,7 @@ const meta = { | |||
| tests, | |||
| isAccepting: false, | |||
| onAccept: action("onAccept"), | |||
| baselineImageVisible: false, | |||
There was a problem hiding this comment.
Should we add a story where it is visible?
weeksling
force-pushed
the
matt/ap-3440-add-toggle-to-show-baseline-snapshot-image
branch
from
60e4e23
to
8f94fc8
Compare
…ests into matt/ap-3440-add-toggle-to-show-baseline-snapshot-image
weeksling
force-pushed
the
matt/ap-3440-add-toggle-to-show-baseline-snapshot-image
branch
from
8f94fc8
to
8441906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the toggle to select between baseCapture and headCapture.
📦 Published PR as canary version:
0.0.33--canary.38.2a60794.0✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.33--canary.38.2a60794.0 # or yarn add @chromaui/addon-visual-tests@0.0.33--canary.38.2a60794.0