Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Storybook with light and dark theme and multiple viewports #6

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 15, 2023

This lays the foundation for our Storybook development environment.

📦 Published PR as canary version: 0.0.4-canary.6.b916e1a.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.4-canary.6.b916e1a.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.4-canary.6.b916e1a.0

Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@weeksling weeksling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple questions about the panels setup, but it works and the rest all looks good to me!

.storybook/preview.tsx Show resolved Hide resolved
.storybook/preview.tsx Show resolved Hide resolved
@ghengeveld ghengeveld merged commit b916e1a into main Jun 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants