Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the "create first build" UI right up until the running build has captured this story #89

Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 8, 2023

We plan to add a in progress indicator to this: https://linear.app/chromaui/issue/AP-3621#comment-1b9a109b, but in the meantime these stories just make sure the selected builds mirror what we want to happen.

@ghengeveld can you let me know if you want a separate ticket for the "first build" in progress UI linked above, or if you just plan to tackle it as part of what you are doing now.

To test:

  1. Create a new branch
  2. You should see the "create first build" screen
  3. Start the build
  4. The screen should remain there (with button disabled) until there is a captured test for the current story.
📦 Published PR as canary version: 0.0.74--canary.89.65ca55a.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.74--canary.89.65ca55a.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.74--canary.89.65ca55a.0

@linear
Copy link

linear bot commented Sep 8, 2023

AP-3645 Don't switch to first build until it has completed

As discussed with m we'll keep the "run your first build" with a progress bar until it finishes

@tmeasday tmeasday changed the base branch from tom/ap-3633-show-snapshot-outdated-header-as-soon-as-we-have-a-new to main September 12, 2023 05:08
@tmeasday tmeasday force-pushed the tom/ap-3645-dont-switch-to-first-build-until-it-has-completed branch from 98ed42b to 2fac687 Compare September 12, 2023 05:14
@ghengeveld
Copy link
Member

@tmeasday Let's make a separate ticket. I don't want to extend the scope of what I'm working on right now.

@tmeasday
Copy link
Member Author

tmeasday commented Sep 13, 2023

TODO after discussion with @MichaelArestad:

  • Ensure you stay on the "first build" screen when you change story (i.e. don't auto select story build)
  • NextBuildInProgress story - not expandable, second eyebrow telling you why you can't review (Reviewing is disabled because there's a newer build in progress on main. This can happen when a build runs in CI.)
  • NextBuildInProgressCapturedStory story - eyebrow should stay until build is done.

@tmeasday
Copy link
Member Author

Going to need to resolve this with your stuff @ghengeveld so I will hold off merging.

@tmeasday tmeasday force-pushed the tom/ap-3645-dont-switch-to-first-build-until-it-has-completed branch from 9233087 to be34a5c Compare September 14, 2023 11:30
@tmeasday tmeasday merged commit 5ee1687 into main Sep 15, 2023
4 of 5 checks passed
@tmeasday tmeasday deleted the tom/ap-3645-dont-switch-to-first-build-until-it-has-completed branch September 15, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants