Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Hide panel in auth and loading states #98

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Sep 13, 2023

What I did:

  • I found that 2 states of the panel were not hiding themselves when active is false.

@linear
Copy link

linear bot commented Sep 13, 2023

AP-3656 New versions of the addon bleed through and break in new projects

There is an issue in some new repos with newer versions of the addon. It causes the visual tests addon to appear over top of other addons.

Screen Shot 2023-09-12 at 6.32.51 PM.png

After some initial testing, this appears to begin in v0.0.51. It was initially discovered in `0.0.66--canary.6774b46.0`

It was also only reproduced in a new project running the latest storybook and few stories.

Testing these same versions in the chromatic monorepo did not seem to reproduce the issue. (worth confirming)

In reference to this report in Slack from joao :

https://chromaticqa.slack.com/archives/C051TQR6QLC/p1694546112948789

@ndelangen ndelangen self-assigned this Sep 13, 2023
@ndelangen ndelangen added the bug Classification: Something isn't working label Sep 13, 2023
@ghengeveld ghengeveld merged commit a21b740 into main Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants