Catch any SyntaxError

chromaui · Mar 28, 2024 · 3a12043 · 3a12043
1 parent 9da6494
commit 3a12043
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/node-src/lib/getConfiguration.test.ts b/node-src/lib/getConfiguration.test.ts
@@ -151,3 +151,24 @@ it('errors if config file contains unknown keys', async () => {
 
   await expect(getConfiguration('test.file')).rejects.toThrow(/random/);
 });
+
+it('errors if config file is unparseable', async () => {
+  {
+    mockedReadFile.mockReturnValue('invalid json');
+    await expect(getConfiguration('test.file')).rejects.toThrow(
+      /Configuration file .+ could not be parsed(.|\n)*Unexpected token i in JSON/
+    );
+  }
+  {
+    mockedReadFile.mockReturnValue('{ "foo": 1 "unexpectedString": 2 }');
+    await expect(getConfiguration('test.file')).rejects.toThrow(
+      /Configuration file .+ could not be parsed(.|\n)*Unexpected string in JSON/m
+    );
+  }
+  {
+    mockedReadFile.mockReturnValue('{ "unexpectedEnd": ');
+    await expect(getConfiguration('test.file')).rejects.toThrow(
+      /Configuration file .+ could not be parsed(.|\n)*Unexpected end of JSON input/m
+    );
+  }
+});
diff --git a/node-src/lib/getConfiguration.ts b/node-src/lib/getConfiguration.ts
@@ -62,10 +62,7 @@ export async function getConfiguration(
         throw new Error(missingConfigurationFile(configFile));
       }
     }
-    if (
-      err.message.match('Unexpected string') ||
-      err.message.match('Unexpected end of JSON input')
-    ) {
+    if (err.name === 'SyntaxError') {
       throw new Error(unparseableConfigurationFile(usedConfigFile, err));
     }
     if (err instanceof ZodError) {