Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to recreate file stream when retrying uploads #11

Closed
tmeasday opened this issue Sep 16, 2019 · 1 comment
Closed

Need to recreate file stream when retrying uploads #11

tmeasday opened this issue Sep 16, 2019 · 1 comment
Assignees
@ndelangen
Labels
bug Classification: Something isn't working

Comments

@tmeasday
Copy link
Member

tmeasday commented Sep 16, 2019 •
edited

See for instance aws/aws-sdk-js#281 (comment)

We need to use async-retry's onRetry to recreate the progress/readstream on error here: https://github.com/chromaui/chromatic-cli/blob/1956-upload-storybook-options/bin/io/upload-to-s3.js#L72
@tmeasday tmeasday added the bug Classification: Something isn't working label Sep 16, 2019
tmeasday added a commit that referenced this issue Sep 16, 2019
@tmeasday
Manually retry uploads, recreating streams each time
8bf0acc 
For #11
@tmeasday tmeasday mentioned this issue Sep 16, 2019
Merged
@tmeasday
Copy link
Member Author

Fixed via #12

ghengeveld pushed a commit that referenced this issue Sep 2, 2020
@ndelangen
ADD comment about fetch-depth (#11)
787f492 
ADD comment about fetch-depth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndelangen ndelangen

Labels
bug Classification: Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmeasday @ndelangen