Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added onTaskComplete callback option #756

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jun 2, 2023

Telescoping on #755

And ability to pass options to the node API.

This will allow us to get access to the context at the completion of each task, in particular to get the build id at the end of the announce task.

@linear
Copy link

linear bot commented Jun 2, 2023

@tmeasday tmeasday requested a review from ghengeveld June 2, 2023 13:11
bin-src/lib/getOptions.ts Outdated Show resolved Hide resolved
bin-src/main.ts Outdated Show resolved Hide resolved
bin-src/lib/tasks.ts Outdated Show resolved Hide resolved
node-src/index.ts Outdated Show resolved Hide resolved
@tmeasday tmeasday force-pushed the tom/ap-3253-update-cli-to-be-callable-from-node-and-return-buildid-2 branch from d1bd329 to 1358e1a Compare June 6, 2023 01:11
@tmeasday tmeasday requested a review from ghengeveld June 8, 2023 03:32
action-src/main.ts Outdated Show resolved Hide resolved
@tmeasday tmeasday force-pushed the tom/ap-3253-update-cli-to-be-callable-from-node-and-return-buildid-2 branch from 0c0916e to 7223c7b Compare June 13, 2023 00:54
Base automatically changed from tom/ap-3253-update-cli-to-be-callable-from-node-and-return-buildid to main June 13, 2023 01:06
@tmeasday tmeasday merged commit aa17ab3 into main Jun 13, 2023
13 of 14 checks passed
@tmeasday tmeasday deleted the tom/ap-3253-update-cli-to-be-callable-from-node-and-return-buildid-2 branch June 13, 2023 01:11
@mattseddon mattseddon mentioned this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants