Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging for turbosnap #758

Merged
merged 12 commits into from
Jun 8, 2023

Conversation

ethriel3695
Copy link
Contributor

I added some debug logging for the traced Files and affected Modules to assist with debugging CI configurations where we are not able to trace files, even with storybookBaseDir and storybookConfigDir

@tmeasday
Copy link
Member

tmeasday commented Jun 5, 2023

@ethriel3695 can you share some examples of what the logs look like before and after?

The things I would like to see added are:

  1. baseDir and storybookConfigDir
  2. Tracing when preview.js etc are matched

@ethriel3695
Copy link
Contributor Author

@tmeasday

I took some screenshots of what the Logs look like with a Base and Config directory, and if there is no trace as well as when a trace is successful.

Screen Shot 2023-06-06 at 7 45 23 AM Screen Shot 2023-06-06 at 7 47 05 AM

I'm also logging what the normalized path looks like.
One is with a baseDir specified. In my example, it's subdir.

Screen Shot 2023-06-06 at 8 13 07 AM Screen Shot 2023-06-06 at 8 13 27 AM

@tmeasday
Copy link
Member

tmeasday commented Jun 6, 2023

Should it be logging the same normalized paths so many times?

@ethriel3695
Copy link
Contributor Author

Should it be logging the same normalized paths so many times?

I've tried a few different options for logging the normalized path, and honestly, I don't love any of the iterations.

What do you think about removing that from the debug log?

@tmeasday
Copy link
Member

tmeasday commented Jun 7, 2023

I think it's better not to have it than to spam it like that.

@ethriel3695
Copy link
Contributor Author

@tmeasday I removed the excessive logs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lets get this merged

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lets get this merged

@tmeasday tmeasday merged commit 23ffaed into main Jun 8, 2023
18 of 19 checks passed
@tmeasday tmeasday deleted the add-logging-for-dependent-story-files branch June 8, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants