Move all depenendencies to dev deps #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to hard merge this one to fix the action (confirmed on canary). |
Closed
|
See https://tsup.egoist.dev/#excluding-packages (I think you needed to add the |
|
That's a good move if we want to revert this PR. Will seek clarification as to whether that's the right direction from others. |
|
@tmeasday so the action absolutely needs everything bundled in, because it has no install step (for performance reasons). The node-api might be different, because you might want to share dependencies. Having them all bundled in might not be a bad situation though, this PR seems fine as is for the foreseeable future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #762
I'm not sure why these utilities were in deps, no dev deps. I think that TSUP will never bundle deps, whereas maybe previously webpack would happily bundle everything? Not sure.