Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipUpdateCheck option #928

Merged
merged 7 commits into from Mar 19, 2024

Conversation

work933k
Copy link
Contributor

@work933k work933k commented Feb 22, 2024

Added option (--skipUpdateCheck) to not check for an updated version of Chromatic. We have over a 100 of Storybook instances which we check with Chromatic. Our private NPM-registry-feed (Azure DevOps artifacts) does not support retrieving the version-info and triggers an error. Having these errors clutters our CI-logs.

This is a non-breaking change and can be marked as #patch

@work933k work933k changed the title feat: skipUpdateCheck option feat: #minor skipUpdateCheck option Feb 22, 2024
@work933k work933k changed the title feat: #minor skipUpdateCheck option feat: skipUpdateCheck option Feb 22, 2024
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for contributing! There's a couple tweaks that need to be made to fully support this option through all config methods (config file, CLI flag, GitHub Action arg, Node API arg). Overall looks good though 👍

node-src/lib/checkForUpdates.ts Outdated Show resolved Hide resolved
node-src/lib/parseArgs.ts Outdated Show resolved Hide resolved
node-src/lib/getOptions.ts Show resolved Hide resolved
@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged minor Auto: Increment the minor version when merged labels Mar 19, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% (target: -1.00%) 62.50%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4e0c1a7) 8431 6635 78.70%
Head commit (d848f32) 8439 (+8) 6640 (+5) 78.68% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#928) 8 5 62.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@ghengeveld ghengeveld changed the title feat: skipUpdateCheck option Add skipUpdateCheck option Mar 19, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Mar 19, 2024
Merged via the queue into chromaui:main with commit 28f2343 Mar 19, 2024
29 of 34 checks passed
@ghengeveld
Copy link
Member

🚀 PR was released in v11.1.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Auto: Increment the minor version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants