Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent non-string or null message in timestamp logging from causing exit code 254 during build. #931

Merged
merged 1 commit into from Mar 8, 2024
Merged

Prevent non-string or null message in timestamp logging from causing exit code 254 during build. #931

merged 1 commit into from Mar 8, 2024

Conversation

BenjaminEllisSo
Copy link
Contributor

Prevent non-string or null message from causing exit code 254 during build.

@BenjaminEllisSo
Update log.ts
ccbf90f 
Prevent non-string message from causing exit code 254
@andrewortwein
Copy link
Contributor

@BenjaminEllisSo is there a specific scenario to reproduce this issue? Just curious how you might have hit this problem.

@JonathanKolnik
Copy link
Contributor

JonathanKolnik commented Mar 5, 2024 •
edited

@BenjaminEllisSo here is a canary version with your fix, can you please confirm it's working as expected? Thank you!

📦 Published PR as canary version: 11.0.2--canary.939.8160747355.0

✨ Test out this PR locally via:

npm install chromatic@11.0.2--canary.939.8160747355.0
# or 
yarn add chromatic@11.0.2--canary.939.8160747355.0

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Mar 5, 2024
@JonathanKolnik JonathanKolnik changed the title Update log.ts Prevent non-string or null message in timestamp logging from causing exit code 254 during build. Mar 8, 2024
@JonathanKolnik JonathanKolnik added this pull request to the merge queue Mar 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2024
@JonathanKolnik JonathanKolnik added this pull request to the merge queue Mar 8, 2024
Merged via the queue into chromaui:main with commit 0fb7fc7 Mar 8, 2024
22 of 27 checks passed
@ghengeveld
Copy link
Member

🚀 PR was released in v11.0.7 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 8, 2024
@BenjaminEllisSo BenjaminEllisSo deleted the BenjaminEllisSo-patch-1 branch March 8, 2024 14:29
@BenjaminEllisSo
Copy link
Contributor Author

Pulled and tested. That resolved it - thank you!!!

@ghengeveld
Copy link
Member

Excellent! Thanks for helping out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghengeveld ghengeveld ghengeveld approved these changes

Assignees
No one assigned
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenjaminEllisSo @andrewortwein @JonathanKolnik @ghengeveld