Fixes for various issues reported by Codacy #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thafryer
approved these changes
Mar 12, 2024
ghengeveld
added
patch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codacy was complaining about some non-literal regexes. These use hardcoded values so they're safe, but that wasn't super obvious. I clarified that by using CONSTANT_CASE for these hardcoded values.
📦 Published PR as canary version:
11.0.9--canary.947.8261414908.0✨ Test out this PR locally via:
npm install chromatic@11.0.9--canary.947.8261414908.0 # or yarn add chromatic@11.0.9--canary.947.8261414908.0