Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell SB8 users to pass --stats-json rather than --webpack-stats-json #948

Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 13, 2024

Storybook 8 now supports generating stats for Vite projects, and so has updated the flag in order to not confuse Vite users. We should do likewise.

📦 Published PR as canary version: 11.1.1--canary.948.8339506025.0

✨ Test out this PR locally via:

npm install chromatic@11.1.1--canary.948.8339506025.0
# or 
yarn add chromatic@11.1.1--canary.948.8339506025.0

@tmeasday tmeasday added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Mar 13, 2024
@tmeasday tmeasday requested a review from thafryer March 13, 2024 04:55
@tmeasday tmeasday force-pushed the tom/ap-4362-cli-should-tell-sb8-users-to-use-stats-json branch from 2416de3 to d0c3ff6 Compare March 13, 2024 07:13
@ghengeveld ghengeveld added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 419e60d Mar 13, 2024
21 checks passed
@ghengeveld ghengeveld deleted the tom/ap-4362-cli-should-tell-sb8-users-to-use-stats-json branch March 13, 2024 08:05
@ghengeveld
Copy link
Member

🚀 PR was released in v11.1.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants