Properly handle GitHub Action inputs that can have multiple values #951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax we currently propose for passing multiple values to an input in the GitHub Action is as follows:
But that will be parsed into a single string with multiple lines that looks like this:
That won't behave as expected when passed along to the CLI.
The correct syntax for this should be like so:
That, along with the changes in this PR to use
getMultilineInput
to get those values will give us an array like we need:That can be passed along to the CLI, which expects a
string[]
for these inputs.How to test
This has been published as
chromaui/action-canary@v1
and the CLI canary is below.Try this out with no values for the inputs, a single value for
externals
, and multiple values with the new syntax forexternals
.📦 Published PR as canary version:
11.1.2--canary.951.8351878886.0
✨ Test out this PR locally via:
npm install chromatic@11.1.2--canary.951.8351878886.0 # or yarn add chromatic@11.1.2--canary.951.8351878886.0