Fix GitHub Action release script using data from Auto shipIt hook rather than from Git #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
force-pushed
the
ghengeveld/ap-4104-github-action-uses-canary-versions-of-the-cli-if-newest
branch
from
0189373
to
7cb657b
Compare
ghengeveld
added
release
ghengeveld
deleted the
ghengeveld/ap-4104-github-action-uses-canary-versions-of-the-cli-if-newest
branch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the
afterShipIthook to automatically release the GitHub Action after releasing to npm. To prevent the wrong contents from being published, the publish-action script was updated to pull context (canary|next|latest) and package version number from theARG_0environment variable provided by Auto, rather than trying to retrieve this info based on the Git branch and repository contents.Furthermore, some log data was added for easier debugging.
📦 Published PR as canary version:
11.1.2--canary.956.8351878580.0✨ Test out this PR locally via:
npm install chromatic@11.1.2--canary.956.8351878580.0 # or yarn add chromatic@11.1.2--canary.956.8351878580.0