Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim v prefix from shipIt's version to avoid double prefixing tags #960

Merged
merged 1 commit into from Mar 20, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Mar 20, 2024

Auto shipIt's newVersion field is prefixed with v (e.g. v11.2.0), whilst the version field in package.json is not. This was causing the tags on the GitHub Action repo to be double-prefixed, e.g. vv11.2.0. Trimming the prefix from newVersion avoids that.

📦 Published PR as canary version: 11.3.1--canary.960.8480061188.0

✨ Test out this PR locally via:

npm install chromatic@11.3.1--canary.960.8480061188.0
# or 
yarn add chromatic@11.3.1--canary.960.8480061188.0

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for cf7b2371
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cf7b237) Report Missing Report Missing Report Missing
Head commit (8b1e88d) 8445 6640 78.63%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#960) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ghengeveld ghengeveld added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Mar 20, 2024
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghengeveld ghengeveld added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 36aa29a Mar 20, 2024
26 of 27 checks passed
@ghengeveld ghengeveld deleted the fix-action-release-tags branch March 20, 2024 15:11
@ghengeveld
Copy link
Member Author

🚀 PR was released in v11.3.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants