Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress issues caused by missing Git remote #962

Merged
merged 1 commit into from Mar 29, 2024
Merged

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Mar 28, 2024

A missing slug (caused by missing Git remote URL) is not a serious problem, so there is no need to log a warning for it. A debug message is more appropriate.

The patch build mechanism attempts to check for remote updates, which when failed should not prevent the patch build from running. In this case a warning is appropriate because it might lead to unexpected results.

📦 Published PR as canary version: 11.2.1--canary.962.8479861319.0

✨ Test out this PR locally via:

npm install chromatic@11.2.1--canary.962.8479861319.0
# or 
yarn add chromatic@11.2.1--canary.962.8479861319.0

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.07% (target: -1.00%) 33.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (36aa29a) 8445 6640 78.63%
Head commit (27723c4) 8449 (+4) 6637 (-3) 78.55% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#962) 12 4 33.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Mar 28, 2024
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghengeveld ghengeveld added skip-release Auto: Preserve the current version when merged and removed release Auto: Create a `latest` release when merged labels Mar 29, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Mar 29, 2024
Merged via the queue into main with commit d00be31 Mar 29, 2024
31 of 33 checks passed
@ghengeveld ghengeveld deleted the suppress-slug-warning branch March 29, 2024 10:36
@ghengeveld
Copy link
Member Author

🚀 PR was released in v11.3.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants