Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Slack plugin for auto to notify on new CLI releases #990

Merged
merged 2 commits into from
May 22, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 22, 2024

This adds the Slack plugin for auto so it will send a webhook notification to our Slack whenever a new CLI version is released. The SLACK_WEBHOOK_URL secret has been setup for this repository.

📦 Published PR as canary version: 11.4.1--canary.990.9191631016.0

✨ Test out this PR locally via:

npm install chromatic@11.4.1--canary.990.9191631016.0
# or 
yarn add chromatic@11.4.1--canary.990.9191631016.0

@ghengeveld ghengeveld added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels May 22, 2024
Copy link
Contributor

@ethriel3695 ethriel3695 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghengeveld is the atTarget the slack channel or the group being pinged?

If it's the slack channel, we should do co-empathy

@ghengeveld
Copy link
Member Author

ghengeveld commented May 22, 2024

@ethriel3695 It's the at-mention target, so that the team gets pinged. The default is @channel which I don't think is desirable. The target channel is configured through the Slack app config.

Copy link
Contributor

@ethriel3695 ethriel3695 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me.
All my questions have been answered as well.

Thanks @ghengeveld !

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 764456e1 (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (764456e) Report Missing Report Missing Report Missing
Head commit (d5c9e61) 8471 6675 78.80%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#990) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ghengeveld ghengeveld added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 24e744c May 22, 2024
22 checks passed
@ghengeveld ghengeveld deleted the setup-slack-webhook branch May 22, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants