Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass SLACK_WEBHOOK_URL to release script #992

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 27, 2024

Unfortunately the last release failed due a missing Slack URL. This URL is configures as an environment variable on the repo, but it needs to be explicitly passed to the release step in the GitHub Action.

📦 Published PR as canary version: 11.5.1--canary.992.9321691749.0

✨ Test out this PR locally via:

npm install chromatic@11.5.1--canary.992.9321691749.0
# or 
yarn add chromatic@11.5.1--canary.992.9321691749.0

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (24e744c) 8471 6675 78.80%
Head commit (711c592) 8471 (+0) 6675 (+0) 78.80% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#992) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@ghengeveld ghengeveld changed the title Pass SLACK_WEBHOOK_URL to release script Pass SLACK_WEBHOOK_URL to release script May 27, 2024
@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels May 27, 2024
Copy link
Contributor

@ethriel3695 ethriel3695 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this and catching it!

@ghengeveld ghengeveld added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 3141b14 May 27, 2024
27 of 28 checks passed
@ghengeveld ghengeveld deleted the pass-slack-env-var branch May 27, 2024 13:41
@ghengeveld
Copy link
Member Author

🚀 PR was released in v11.5.0 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants