Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infinite loading for 307 and 308 response statuses #15

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix infinite loading for 307 and 308 response statuses #15

merged 1 commit into from
Sep 5, 2023

Conversation

joshuajaco
Copy link
Contributor

Issue: #13

What Changed

Applies the same behavior from 301 and 302 response status codes also for 307 and 308.

How to test

See https://github.com/joshuajaco/playwright-chromatic-redirect-issue/blob/main/some.test.ts

Change Type

  • maintenance
  • documentation
  • patch
  • minor
  • major

tevanoff
tevanoff approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@tevanoff tevanoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch. Thanks for the fix @joshuajaco! 🙌

@tevanoff tevanoff merged commit 8840121 into chromaui:main Sep 5, 2023
@tmeasday
Copy link
Member

tmeasday commented Sep 5, 2023

🚀 PR was released in v0.0.20 🚀

@tevanoff tevanoff mentioned this pull request Sep 5, 2023
Closed
@joshuajaco joshuajaco deleted the fix-redirects branch September 6, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tevanoff tevanoff tevanoff approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshuajaco @tmeasday @tevanoff