Do not archive top level page requests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevanoff
changed the title
tevanoff
force-pushed
the
todd/ap-3628-eisdir-illegal-operation-on-a-directory
branch
from
01dabbe
to
774e9fe
Compare
tevanoff
changed the base branch from
steven/use-playwright-test-result-folder
to
main
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
What Changed
This stops the archiving of the top-level page request that's initiated via
page.goto('/some/path'). The response of this page is not needed and saving it can cause some file path conflicts as described in the issue above.How to test
Run this against the sample repository in #14
Change Type
maintenancedocumentationpatchminormajor📦 Published PR as canary version:
0.0.22--canary.19.774e9fe.0✨ Test out this PR locally via:
npm install @chromaui/test-archiver@0.0.22--canary.19.774e9fe.0 # or yarn add @chromaui/test-archiver@0.0.22--canary.19.774e9fe.0