🥅 Make Watcher not throw an exception if network idle times out #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AP-3761.
Issue: AP-3761
What Changed
Previous to this,
Watcher
would throw an exception if the global network idle timer timed out. This changes it to not throw an error, and instead log the error and move on. It also adjusts the default timeout to be configurable, defaulting to 10s.How to test
Follow the reproduction steps in AP-3761.
Change Type
maintenance
documentation
patch
minor
major
📦 Published PR as canary version:
0.0.29--canary.25.4e99d70.0
✨ Test out this PR locally via:
npm install @chromaui/test-archiver@0.0.29--canary.25.4e99d70.0 # or yarn add @chromaui/test-archiver@0.0.29--canary.25.4e99d70.0