Fix mapping of CSS URLs #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevanoff
force-pushed
the
todd/fix-css-attribute-mapping
branch
from
07977d7
to
f9c5b5b
Compare
thafryer
approved these changes
Nov 10, 2023
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CAP-1329
What Changed
When we need to rewrite an asset path, we're currently only updating the
srcattribute on DOM nodes. If an asset loaded from a CSS file orstyleattribute was rewritten, it will fail to load because the CSS will reference the old path when the snapshot is rendered.This goes through the contents of
styleattributes andstyleelements and replaces anyurlreferences as needed.There's still one empty box in the E2E Storybook due to a missing asset, but that's due to CAP-1194. I believe getting rid of the rrweb fork, which can be a follow up to this, will resolve that.
How to test
Change Type
maintenancedocumentationpatchminormajor📦 Published PR as canary version:
0.0.37--canary.33.f9c5b5b.0✨ Test out this PR locally via:
npm install @chromaui/test-archiver@0.0.37--canary.33.f9c5b5b.0 # or yarn add @chromaui/test-archiver@0.0.37--canary.33.f9c5b5b.0